Comment TraceLevelInfoFilter as it breaks OTel compatibility #21
Conversation
|
Also cc @thrawn01 just in case :) |
|
There have been so many golang mod compatibility errors with otel, over the past few months. I'm beginning to wonder if it's worth the hassle. The maintainers of different otel libraries don't appear to be managing releases properly. 😞 |
|
For my Ref: open-telemetry/opentelemetry-go-contrib#4575 no deprecation notice, with no suggestions of an alternative. 👎 |
|
Just seeing this. Thank you! Yes it seems that having an OTel dependency can make things difficult. I made this PR recently too. Thanks for merging this PR |
I'm inclined to agree. I use some other packages that recently switched (somewhat forced) to otel as well and it seems like it might becoming a bit of a nightmare dependency. |
TraceLevelInfoFilterisn't used - its only use was ingubernator/daemon.go
Line 116 in e054be3
This PR unblocks consumers of gubernator who also use the latest OTel libraries (version 0.52), as the type
otelgrpc.Filterchanged in open-telemetry/opentelemetry-go-contrib#5196 ). See change here. The code I commented is now invalid with latest versions of OTel, which prevents consumers of OTel libraries to upgrade them if they also use gubernator. Building gubernator with the latest OTel libraries fails with:Allegedly this could now be fixed with the merge of the above PR (and the code in daemon.go could be uncommented), but it requires a larger change.
I am opening this PR to unblock users of OTel and gubernator as it is the most pressing issue.
Commenting feels a bit weird (I did it because of the commented code in daemon.go), let me know if you want to address this differently.